edge-runtime icon indicating copy to clipboard operation
edge-runtime copied to clipboard

Fix: Convert cookie attribute "sameSite" of TRUE to "strict" as per documentation

Open Heinrich-Barth opened this issue 1 year ago • 2 comments

This PR addresses the following issue:

Per documentation, the cookie attribute sameSite should convert the boolean value of "true" to "strict".

This is not the case. Instead, a cookie will have an invalid value, e.g.

session=anyvalue; Path=/; SameSite=true

expected cookie String should (per documentation) should be

session=anyvalue; Path=/; SameSite=strict

This patch converts the boolean true to "strict" as per documentation.

Heinrich-Barth avatar Jan 09 '25 19:01 Heinrich-Barth

⚠️ No Changeset found

Latest commit: 7f0ff376e7f337e128306bd92b72622e86eef5c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 09 '25 19:01 changeset-bot[bot]

@Heinrich-Barth is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 09 '25 19:01 vercel[bot]

Am I correct in assuming that this repository is not maintained anymore?

Heinrich-Barth avatar Jul 08 '25 19:07 Heinrich-Barth