commerce
commerce copied to clipboard
vercel
vendure custom checkout support #619
@hangai247 is attempting to deploy a commit to the Vercel Solutions Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
commerce-local – ./site
🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-local/7doV2szZceyEuorQRaHSasVSkhrW
✅ Preview: https://commerce-local-git-fork-hangai-d94eab-vercel-solutions-vtest314.vercel.app
Relates to #619 @okbel FYI this was done in coordination with me in the Vendure slack. Soninkhangai has agreed to take on some maintenance of this integration 👍
Hey @michaelbromley
Is there an ETA for this feature to be merged?
cc: @hangai247
@briandiaz I don't know, I'm not a maintainer of this repo so I cannot decide that unfortunately 😢
@hangai247 Could you please add a Description to the PR to understand all you're adding please? We can review it and merge it.
@michaelbromley Does this have your approval from the Vendure perspective? All approved practices?
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| commerce-commercejs | ✅ Ready (Inspect) | Visit Preview | Aug 17, 2022 at 2:06PM (UTC) |
| commerce-ordercloud | ❌ Failed (Inspect) | Aug 17, 2022 at 2:06PM (UTC) | |
| commerce-shopify | ✅ Ready (Inspect) | Visit Preview | Aug 17, 2022 at 2:06PM (UTC) |
| commerce-swell | ✅ Ready (Inspect) | Visit Preview | Aug 17, 2022 at 2:06PM (UTC) |
| commerce-vendure | ❌ Failed (Inspect) | Aug 17, 2022 at 2:06PM (UTC) |
@okbel I'm just pulling this PR in locally to try it out. Unfortunately just had to spend ages trying to resolve https://github.com/vercel/commerce/issues/674 (in the end I used the suggested fix at https://github.com/vercel/commerce/issues/681#issuecomment-1041921734 to get it working). Will update this PR with my feedback.
@okbel ok I ended up having to make a bunch of fixes. @hangai247's work on this PR is excellent, so it was mainly just polishing up a few things and handling some cases in the checkout flow that weren't already covered. This is in a new PR at #760.
Hey! Following up here. Is this something you're still interested in seeing through?
