Linting methods

[artskidesign]

Is there a reason why we’re combining the use of Biome and ESLint in this project instead of fully shifting to Biome and dropping ESLint? I might be missing something and wanted to check if there’s a specific reason for this split between the two as it currently stands.

[JinJieBeWater]

I also wonder why this is

[0Chan-smc]

Does anyone know the reason for this?

[GitTom]

And I think there are other problems with the way that lint/biome are being used ...

Running pnpm lint on this repo changes many of the source files (it removes the type keyword from imports).

So, on every commit, lint is running in the actions, changing all the code, and then throwing the changes away. No harm, but seems like a bad idea.

package.json includes

    "lint": "next lint && biome lint --write --unsafe",
    "lint:fix": "next lint --fix && biome lint --write --unsafe",

I think it shouldn't have the biome --write --unsafe options on the lint - just on the lint:fix.

Also, if the lint:fix command, as configured, wants to remove all those type keywords, I guess they should be removed - so lint:fix is clean.

[haydenbleasel]

We'll be fully moving to Biome in our next major release (in progress) 👍