patrol icon indicating copy to clipboard operation
patrol copied to clipboard

Need a better handler for the auth IPs

Open jesuismaxime opened this issue 4 years ago • 4 comments

It would be better if the plugin uses the database to store the IPs or at least merge the list from the patrol.php file with one from the project.yaml. The fact that only one of them is working is an issue when working with multiple environment. I juste wiped out my production IPs list because my local environment doesn’t have all the production auth IPs.

This will also allow changes in production when the Craft setting allowAdminChanges is net to false. For now it display a system error because the plugin isn’t able to push changes to the yaml file.

jesuismaxime avatar Jun 29 '20 13:06 jesuismaxime

Agreed. Not quite sure what the thinking was for re-saving plugin settings but that won't work at all on environments with allowAdminChanges = false.

engram-design avatar Jul 26 '22 06:07 engram-design

Any update regarding this? Really need to have Patrol activated on staging/production environments where admin changes are not allowed.

jesuismaxime avatar Aug 23 '22 20:08 jesuismaxime

No update yet, sorry - but it'll take a little bit to get that sorted, and backwards-compatible.

Planning this to only be available for Craft 4 though, if that factors in on your end.

engram-design avatar Aug 25 '22 03:08 engram-design

A bit late to the party bit I just bumped into this on Craft 5. The token adding an ip is a great function, but I have admin changes disabled on staging and live servers, so it just throws a server error.

bartrylant avatar Sep 14 '24 17:09 bartrylant