go-cose icon indicating copy to clipboard operation
go-cose copied to clipboard

Support for CWT Claims in Headers

Open OR13 opened this issue 2 years ago • 6 comments

What is the areas you would like to add the new feature to?

Go-COSE Library

Is your feature request related to a problem?

See https://datatracker.ietf.org/doc/draft-ietf-cose-cwt-claims-in-headers/

What solution do you propose?

See https://datatracker.ietf.org/doc/draft-ietf-cose-cwt-claims-in-headers/

What alternatives have you considered?

None.

Any additional context?

Once this document becomes an RFC it is advisable to add support for it to protected headers.

OR13 avatar Sep 12 '23 17:09 OR13

Blocked (labeled) pending the RFC

SteveLasker avatar Oct 06 '23 15:10 SteveLasker

its still progressing, the code points have changed.

its also debatable if this should be done in this repo, will there be a go-cwt ?

OR13 avatar Dec 01 '23 16:12 OR13

@thomas-fossati @qmuntal do you think we should do all the CWT stuff in a seperate repo? if so, this issue should probably be closed.

OR13 avatar Dec 01 '23 16:12 OR13

@thomas-fossati @qmuntal do you think we should do all the CWT stuff in a seperate repo?

hi @OR13! I've just glanced through the draft and, unless I'm mistaken, there is no special processing that needs to happen at the COSE layer. So, apart from adding the registered "CWT Claims" code-point into the consts list in headers.go, I don't see any other actions for go-cose.

if so, this issue should probably be closed.

We can keep this open until the IANA registration has completed, at which point we add the const and close it.

thomas-fossati avatar Dec 04 '23 10:12 thomas-fossati

@OR13 agreed to initiate a PR for review.

SteveLasker avatar Jan 26 '24 16:01 SteveLasker

PR is up here: https://github.com/veraison/go-cose/pull/183

OR13 avatar Jan 26 '24 17:01 OR13