VeraCrypt icon indicating copy to clipboard operation
VeraCrypt copied to clipboard

Allow compilation with g++17 by replacing "byte" with "uint8_t" to remove confusion with std::byte (c++17 feature)

Open segfaultDelirium opened this issue 7 months ago • 1 comments

C++17 features std::byte which breaks "byte" definitions in Crypto++ library. This pull requests fixes this.

segfaultDelirium avatar Jan 10 '24 10:01 segfaultDelirium

This change breaks Windows build. A better approach is to replace byte by uint8 that is specifically defined in Tcdefs.h in order to be available in all platforms.

Can you change your PR to se this approach.

idrassi avatar Apr 10 '24 15:04 idrassi

I have implemented a similar change using the uint8 type as I mentioned earlier: https://github.com/veracrypt/VeraCrypt/commit/455a4f2176a5cfbe325e1e40cea20dd3e466b64c So closing this PR.

idrassi avatar Jun 14 '24 06:06 idrassi