Vincenzo Eduardo Padulano
Vincenzo Eduardo Padulano
@martamaja10 @pcanal @hageboeck @dpiparo The latest commits includes the final naming scheme for the API extension: * `DefaultValueFor(colname, defaultval)`: lets the user provide one default value for the current entry...
> If I read that correctly, it keeps only the entries for which that column has no entries, right? (i.e. as a consequence there should be not use of that...
> Thanks Vincenzo! It all looks good to me - just one quick question, since now there is "FilterMissing" as well, should it be added to the tutorials as well...
Wait, this should have been fixed by https://github.com/root-project/root/pull/13900. If that's not the case, we need to understand why. FYI @pcanal .
The original issue (which was "fixed" by also removing the transient unique_ptr because it was blocking the transition to C++17) is at https://github.com/root-project/root/issues/13361 I couldn't create a standalone reproducer back...
> e.g. LHC experiments, of this change in case something behaves differently in that context. This move is necessary for the Python environments but there is a clear limitation in...
Thank you @guitargeek I believe this PR can be closed now!
Added backwards-compatibility test in roottest, will wait for the CI to run.
Failures are unrelated, merging this PR due to its relevance for the upcoming patch release.
It's still one less patch needed for the conda packaging. Clearly there's a bigger rock to move, but this smaller one could be moved anyway perhaps?