Documentation needs improvement
I am impressed with ventoy, less so with vtoydump.
It would be helpful in your readme if you stated that vtoydump has to be run with admin privileges. That would have saved me time scratching my head wondering why it did not work, i.e. sudo vtoydump.
In the git package there is a binary, vtoydump64. I have two custom isos, one built off ubuntu 18.04 (bionic) the other 20.04 (focal). sudo vtoydump64 worked in the focal iso, it did not in the bionic iso, vtoydump64: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.28' not found (required by vtoydump64). Can I install a later version of libc6 in bionic - NO. If you are going to include binaries, a version built on older ubuntu/debian would be more helpful.
So I installed ubuntu 18.04 in a VM. Is there any documentation stating what packages are required to build using your build.sh script - NO. I guessed build-essential would probably be required, installed it. Ran script - error. It took some googling on the error to find out I also needed to install gcc-multilib. Did the script then run without error - NO. Looking at the build folder I have 32 and 64 bit versions of vtoydump, what is happening? More googling.
If you want to build both AMD and ARM versions of vtoydump in the same script you could at least have a menu:
- AMD version.
- ARM version.
- Both. Enter 1, 2 or 3:
and wrap the build code in a case or if statement. It is not difficult. Did the version of vtoydump built in bionic work in both my isos - YES.
You want devs to make their isos 'ventoy compatible' and ventoy is a good product, but being generous - your documentation and build script for vtoydump is sloppy. Want us to support ventoy, you need to improve.
All you have done here is leave one dev irritated.
The document and build script have been improved. Static build linux binraries are included.