WheelView icon indicating copy to clipboard operation
WheelView copied to clipboard

setSelection delay

Open ahaverty opened this issue 9 years ago • 2 comments

Hi @venshine, Thanks for a great repo! I was just talking with @w3bfr3ak in #16 about the setSelection method. It seems that we both have uses for setting the selection while the wheel is being used. However, your repo uses postDelay and setVisibility causing a >.5 second delay. I've modified it in my fork to remove the delay and toggling and haven't seen any issues on my end. Was there a reason you used a delay? If not, would you like me to make a pull request?

My small change is here: https://github.com/ahaverty/WheelView/blob/master/wheelview/src/main/java/com/wx/wheelview/widget/WheelView.java#L379 Dependency on jitpack https://jitpack.io/#ahaverty/WheelView/1.3.4

Google translate version: 嗨@venshine ,谢谢你为一个伟大的回购! 我在 #16 对setSelection方法, @w3bfr3ak 只是谈论。看来,我们都有设置的选择,而正在使用的轮用途。但是,您的回购使用postDelay和setVisibility造成 > .5,秒的延迟。我在我的叉子去掉延迟和反复修改,并没有看到我的结束的任何问题。有没有你使用的延迟的一个原因?如果没有,你要我做一个拉要求?

我小的变化是在这里: https://github.com/ahaverty/WheelView/blob/master/wheelview/src/main/java/com/wx/wheelview/widget/WheelView.java#L379

Dependency on jitpack https://jitpack.io/#ahaverty/WheelView/1.3.4

ahaverty avatar Aug 20 '16 15:08 ahaverty

thanks!关于gong->visible延迟5秒问题,谢谢您的指点

liyujiang-gzu avatar Mar 08 '17 14:03 liyujiang-gzu

@ahaverty Well, I hope you make a pull request to help me resolve this problem of delay. Thanks.

venshine avatar Mar 09 '17 14:03 venshine