storefront-remix-starter icon indicating copy to clipboard operation
storefront-remix-starter copied to clipboard

Add Vercel deploy config and platform specific tweaks

Open dmi3y opened this issue 11 months ago • 3 comments

  • Add specific Vercel deploy config
  • Use regular dynamic import vs safe import

Assume Vercel does some pre-optimization and if left as safe import it breaks deployment, that likely increases bundle size though. Not sure what could be a better alternative.

related to https://github.com/vendure-ecommerce/storefront-remix-starter/issues/67

dmi3y avatar Mar 08 '24 22:03 dmi3y

Deploy Preview for inspiring-boba-355f4d ready!

Name Link
Latest commit 7004bba48c029491a687cf3bfcbaba5b190dc1cd
Latest deploy log https://app.netlify.com/sites/inspiring-boba-355f4d/deploys/65fe803888bb0e000846e7d2
Deploy Preview https://deploy-preview-75--inspiring-boba-355f4d.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 08 '24 22:03 netlify[bot]

Deploy Preview for remix-vendure ready!

Name Link
Latest commit 7004bba48c029491a687cf3bfcbaba5b190dc1cd
Latest deploy log https://app.netlify.com/sites/remix-vendure/deploys/65fe80385c8b5800080d69ff
Deploy Preview https://deploy-preview-75--remix-vendure.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 08 '24 22:03 netlify[bot]

Oh, I see now it's broken on Netlify deploy :(

PS: Though I see same broken deploys on previously merged PR 🤔

dmi3y avatar Mar 08 '24 23:03 dmi3y