storefront-angular-starter icon indicating copy to clipboard operation
storefront-angular-starter copied to clipboard
verified publisher icon vendure-ecommerce

Site hanged if Discount products with these facets by 5% is active

Open hkjeffchan opened this issue 5 years ago • 3 comments

The shop hanged if discount is applied with facet rules.

Tried firefox and chrome with the latest verison.

hkjeffchan avatar Jun 26 '20 10:06 hkjeffchan

Reproduction:

  1. Create a Promotion with 5% off all products with the "photo" facetValue
  2. In the demo storefront, add a camera to the order
  3. Browser hangs.

Most likely an infinite change-detection loop in Angular.

michaelbromley avatar Jun 26 '20 11:06 michaelbromley

I am trying to simulate here. But Looks like it's fine. is order the same as Cart?

talesmgodois avatar Aug 10 '20 20:08 talesmgodois

@talesmgodois Yes, Order is the name of the entity used by the server, whereas "Cart" is used in the storefront as a more familiar term for customers.

michaelbromley avatar Aug 12 '20 15:08 michaelbromley