ultra icon indicating copy to clipboard operation
ultra copied to clipboard
verified publisher icon venantius

[ultra] Require nrepl or clojure.tools.nrepl dynamically

Open venantius opened this issue 7 years ago • 5 comments

clojure.tools.nrepl is now officially deprecated and has been replaced with nrepl/nrepl. This commit updates all direct references to clojure.tools.nrepl to use a dynamic import that checks to see if clojure.tools.nrepl is on the path and otherwise to use the new nrepl.

As we rely on a significant amount of functionality in Whidbey/Puget, those will also need to have their references updated.

This PR resolves #95

venantius avatar Dec 14 '18 11:12 venantius

@venantius any updates on this issue (#95)? i see greglook/whidbey#26 is already resolved

buzzdan avatar Jan 20 '19 05:01 buzzdan

I'll try to give this a look over the weekend.

venantius avatar Jan 21 '19 13:01 venantius

@venantius Thanks for looking at this, any chance we could get it over the line please?

elzibubble avatar Jan 29 '19 08:01 elzibubble

Leiningen 2.9.0 has introduced some sort of new issue that needs to be resolved upstream again - not totally clear what it is yet. I could try to fix this just for Lein 2.8.3 but I'd rather just fix it for 2.9.0 onwards.

venantius avatar Feb 14 '19 15:02 venantius

Reference: https://github.com/greglook/whidbey/issues/27

venantius avatar Feb 14 '19 15:02 venantius