Jonas Cosandey

Results 22 comments of Jonas Cosandey

Im still having this issue, in my case this happens if i add a `async` to my `beforeModel` hook. After that, every test which renders this route throws a `TransitionAborted`.

Im returning nothing: ```js async beforeModel() { if (logic) { await something; } if (!logic2) { this.replaceWith("/some/url"); } } ``` Should i put a `return` before `this.replaceWith`? If yes, can...

@rwjblue Hmm in my failing test the problem occurs even with a `return` could there be another problem that im not aware of?

Sadly i cant really debug it since the stack trace is just backburner calls. And stepping through the `this.replaceWith` was not as helpful as i thought.

@trowik Is this still an issue or has this been implemented already?

Ah thanks! I misunderstood the following that all characters , if balanced, can be used inside. But that's of course only for grouping characters. > Nested pairs of the braces...

This would be ready for review now.

Hey @mawww It's been a long time but i added the waiver commit to the PR. Thanks for leaving this open so long.

@mawww ping, if your still willing to merge this.