Airshipper icon indicating copy to clipboard operation
Airshipper copied to clipboard

Fixes bug which prevented Airshipper launching on Windows (as attempted 23Apr24 and 24Apr24)

Open mrexcessive opened this issue 1 year ago • 6 comments

Updated client/src/windows.rs So that all 4 invocations of .asset_for(,) provide a second required Option<,> parameter. Note that this fix provides None

But it seems to work and the client launches fine, and the game runs fine.

See discussion here, https://www.reddit.com/r/Veloren/comments/1caz7vn/is_there_a_stable_windows_build_airshipper_doesnt/

mrexcessive avatar Apr 24 '24 15:04 mrexcessive

The project doesn't build (tested on Windows) without this patch, or something like it (you may have a better solution).

mrexcessive avatar Apr 24 '24 15:04 mrexcessive

This repo was moved to https://gitlab.com/veloren/airshipper (and the github is now a mirror)

Imberflur avatar Apr 24 '24 20:04 Imberflur

OK I don't have an account on gitlab. Maybe someone else can apply the patch and fix the windows distro.

mrexcessive avatar Apr 25 '24 02:04 mrexcessive

@mrexcessive sounds good, will try to remember to post here when it is applied

Imberflur avatar Apr 26 '24 14:04 Imberflur

it will be included when this is merged https://gitlab.com/veloren/airshipper/-/merge_requests/122

Imberflur avatar Apr 26 '24 15:04 Imberflur

Thanks so much @Imberflur :) Appreciate your help!

mrexcessive avatar Apr 26 '24 16:04 mrexcessive