velocyto.py icon indicating copy to clipboard operation
velocyto.py copied to clipboard

Seems like a typo.

Open chenqiuhao opened this issue 2 months ago • 0 comments

https://github.com/velocyto-team/velocyto.py/blob/0963dd2df0ac802c36404e0f434ba97f07edfe4b/velocyto/analysis.py#L258

The code is: if min_expr_cells <= ((100 - winsor_perc[1]) * self.S.shape[1] * 0.01): min_expr_cells = int(np.ceil((100 - winsor_perc[1]) * self.S.shape[0] * 0.01)) + 2 logging.debug(f"min_expr_cells is too low for winsorization with upper_perc ={winsor_perc[1]}, upgrading to min_expr_cells ={min_expr_cells}")

Is it should be "min_expr_cells = int(np.ceil((100 - winsor_perc[1]) * self.S.shape[1] * 0.01)) + 2"? self.S.shape[0] ---> self.S.shape[1]

chenqiuhao avatar May 29 '24 07:05 chenqiuhao