gtktitlebar
gtktitlebar copied to clipboard
WIP: Add GNOME 45 support
Addresses #38
-
[x] Fix imports
-
[x] Fix file structure
-
[ ] Fix preferences window (WIP)
-
[ ] Fix main functionality
Tks a lot for your work on the portage. Have you got an idea of when it may be ok for a go? Cheers
@Neo-29 I will continue working on it once I upgrade to G45 to test it. Feel free to share any errors/suggestions you have on the current state of port
@Neo-29 I will continue working on it once I upgrade to G45 to test it. Feel free to share any errors/suggestions you have on the current state of port
With pleasure. But is it quite usable as is with this commit?
The settings of extension [email protected] had an error:
Error: Expected an object of type GObject for argument 'object' but got type undefined
Stack trace:
createCheckedMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:730:46
fillPreferencesWindow@file:///home/neo29/.local/share/gnome-shell/extensions/[email protected]/prefs.js:9:19
_loadPrefs@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:36:18
async*_init@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:21:14
ExtensionPrefsDialog@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:12:4
OpenExtensionPrefsAsync@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:139:33
async*_handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:373:35
_wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34
This extension is active with your patch but doesn't hide all the windows title either on wayland nor on x11
@Neo-29 I did not rework settings yet, I think we should start with main functionality (e.g. hiding titlebard) first
@Neo-29 I did not rework settings yet, I think we should start with main functionality (e.g. hiding titlebard) first
I rechecked. It doesn't work on any windows here. So yes.. Function first.
@velitasali probably you could take a look
Hi @ExposedCat. Thank you for working on this. The extension only works with X11 apps, and uses xprop to modify a window property of the _MOTIF_WM_HINTS
. I don't think how that property is defined changed since X11 is no longer developed, but probably mutter started to handle it differently. Also, more apps will also probably stop working after their switch to Wayland protocol. That is why I am considering a different approach. I haven't checked if it would work yet, but we should be able to modify the window properties using the existing API that the shell exposes to the extensions, assuming https://github.com/yilozt/rounded-window-corners also uses the similar APIs to make window corners rounded.
@velitasali that sounds great. If you are working on some branch and have old code there, i.e. needed port - feel free to drop it here, I will cherry-pick changes there (within a PR). If you haven't started yet - we can create a new branch for it 😃
@velitasali that sounds great. If you are working on some branch and have old code there, i.e. needed port - feel free to drop it here, I will cherry-pick changes there (within a PR). If you haven't started yet - we can create a new branch for it 😃
Could be great!
@velitasali @ExposedCat have you any info about update? :slightly_smiling_face: