Results 285 comments of Vasil Velichkov

Hi @acetcom, I just pushed 3 commits in my fork - two APER fixes (fec0acc058491b60eb00cd223de246b168b69f92, f5dc5cc6358a153cd0e0da503563c595d2a2edd4) and one XER (8d06d92df6dca1b9a6dcb0aedef0f91e053823d0) ```bash $ file ./s1ap-dump ./s1ap-dump: ELF 32-bit LSB executable, Intel...

Hi @mouse07410, > @velichkov what branch of your fork should I cherry-pick those three commits from The branch name is `s1ap` and is based on the brchiu's `s1ap` branch. >...

Hi @mouse07410, > Could you tell me what s1ap branch is, and how it is related to your master and to vlm/master My master is pretty out of date because...

Hi @mouse07410, > a fix for #252 provided in #260 (BTW, @velichkov what do you think of this fix? It looks fine to me, but I don't have a 32-bit...

Hi @mouse07410, > but would you mind taking a look at the fix I applied to skeletons/INTEGER.c, and comment on whether the added checks are sufficient in your opinion? I...

Hi @acetcom, > srsenb.pcapng : Wireshark packet capture. E-RAB Setup Response captured in number 36. > e_rab_set_response.png : screen shot > Basically, I have no idea whether srsENB encoding is...

Hi @gareins, @pitzor, Unfortunately there is no `*_copy` functions for the various structures yet. Having a generic ASN_STRUCT_COPY (similar to ASN_STRUCT_FREE) could be really useful in some use cases and...

From https://github.com/mouse07410/asn1c/issues/44#issuecomment-477600095 I think using `CHOICE_encode_oer` to encode `Open Types` is incorrect and the reason for the above differences. [skeletons/OPEN_TYPE.h#L23](https://github.com/mouse07410/asn1c/blob/86b05417584ac3f2b820bdd5719516ba2039086e/skeletons/OPEN_TYPE.h#L23) ```c #define OPEN_TYPE_encode_oer CHOICE_encode_oer ``` This line was added in...

Hi @vlm, > Is there a way to support both bison 2 and bison 3? For me this fix works well with bison 2.5 and 3.0.2. Only one compiler warning...

Hi @nnWhisperer, > How could we split the stream successfully into uper_decode'able packets? From [asn1c-usage.pdf](https://github.com/vlm/asn1c/raw/34df4e579942f13c07f7be07580d10301dc08d40/doc/asn1c-usage.pdf). > 4.2 Decoding BER > > The decoder is restartable (stream-oriented). That means that in...