vega icon indicating copy to clipboard operation
vega copied to clipboard

[Bug]: Tech Debt - Remove wipe flag from datanode

Open ettec opened this issue 2 years ago • 0 comments

Problem encountered

Prior to the initial release we had planned to remove the flag below (unsafe-reset-all command was added in its place), but due to release timelines and the changes this would require to tests and pipelines it was left in place. Apart from being legacy cruft the flag is misleading as it empties both the SQL store and the network history store. Will need to rework pipelines and system tests before removing this flag.

if l.conf.SQLStore.WipeOnStartup {
		if ResetDatabaseAndNetworkHistory(l.ctx, l.Log, l.vegaPaths, l.conf.SQLStore.ConnectionConfig); err != nil {
			return fmt.Errorf("failed to reset database and network history: %w", err)
		}
	}

Observed behaviour

"

Expected behaviour

"

Steps to reproduce

"

Software version

develop

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

ettec avatar Oct 13 '23 09:10 ettec