vegaprotocol
Nullblockchain blocks self-transaction while time-forwarding
Problem encountered
When the nullblockchain moves time forward it locks itself and prevents any new transactions making it into the blocks created while it steps forward in time. This causes problems when the core node sends transaction to itself, like node-votes, or state-variable transactions.
The result is that these transactions build up until the time-forward stops and then are pushed all at once into core, moving time forward some more (for example if transactions-per-block is set to 1, time will be pushed forward by 1 second for each built up transaction).
This isn't correct because these transaction need to come in at the right time. So we need a way to allow new transactions to dip in as time-forwarding happens.
Automation
Link to automation and explanation on how to run it to reproduce the problem/bug
Evidence
Logs
If applicable, add logs and/or screenshots to help explain your problem.
Additional context
Add any other context about the problem here including; system version numbers, components affected.
Definition of Done
ℹ️ Not every issue will need every item checked, however, every item on this list should be properly considered and actioned to meet the DoD.
Before Merging
- [ ] Code refactored to meet SOLID and other code design principles
- [ ] Code is compilation error, warning, and hint free
- [ ] Carry out a basic happy path end-to-end check of the new code
- [ ] All APIs are documented so auto-generated documentation is created
- [ ] All bug recreation steps can be followed without presenting the original error/bug
- [ ] All Unit, Integration and BVT tests are passing
- [ ] Implementation is peer reviewed (coding standards, meeting acceptance criteria, code/design quality)
- [ ] Create front end or console tickets with feature labels (should be done when starting the work if dependencies known i.e. API changes)
After Merging
- [ ] Move development ticket to
Doneif there is NO requirement for new system-tests - [ ] Resolve any issues with broken system-tests
- [ ] Create documentation tickets with feature labels if functionality has changed, or is a new feature
