frontend-monorepo icon indicating copy to clipboard operation
frontend-monorepo copied to clipboard

Improve fee table labels and visual hierarchy, add maker rebate column

Open barnabee opened this issue 7 months ago • 0 comments

The columns in this fees table are not labelled in line with industry norms, and it's not clear that three of the columns are a breakdown of another column rather than separate fees:

Screenshot 2024-07-18 at 11 11 46

Labels should be updated as follows:

Total fee after discountTaker fee after discount Total fee before discountTaker fee before discount

We need to make the fee components much more clearly a breakdown of the fee before discount, perhaps we can use larger fonts for the two total fees and a more muted colour for the fee components. If there was a way to make this hierarchy/breakdown even more clear, or even to hide the breakdown initially, that'd be good.

It would also be worth adding a maker rebate column which would need to show a range from the lowest (with maxed out discounts) to the highest (the maker fee component amount) rebate that a maker woudl receive.

This table needs to be redesigned when the new fee components in https://github.com/vegaprotocol/specs/issues/2295 and the dynamic maker fee landhttps://github.com/vegaprotocol/specs/issues/2296 land, but the above should be good for now.

barnabee avatar Jul 18 '24 10:07 barnabee