frontend-monorepo icon indicating copy to clipboard operation
frontend-monorepo copied to clipboard

Confirm closing position and orders from positions table

Open barnabee opened this issue 7 months ago • 1 comments

Description

Suggestion to add a popup/modal to the "close position" button to allow a user to confirm closing their position when they click the [ × ] button on the position table, and to select whether to also cancel their active orders.

This was requested by a user on Discord or the forums a little while back (I forget which) and is especially needed where auto confirm is enabled in the wallet so there's literally no confirmation before the txn is sent.

Also, while using the front end myself I've found that probably >50% of the time I want to close the position but keep any open orders, and other times I want to cancel the orders too, hence the suggestion to combine the confirmation with deciding whether orders should be cancelled too.

I've suggested two different ways a modal/popover could look below.

Example modal layout

e.g.


                                 Confirm closing position on BTC/USDT.PERP


                 [ Cancel ]       [ Close position only ]       [ Close position and orders ] 

OR


                                   Confirm closing position on BTC/USDT.PERP

                                      [ x ] Also close all active orders


                                [ Cancel ]       [ Close position [and orders] ] 

Acceptance Criteria

  • [ ] User is required to confirm via a modal or popover when they click th [ × ] button to close a position
  • [ ] The modal/popover has an option to cancel, which dismisses it completely with no further action
  • [ ] The modal/popover has an option to close the position, which sends the close transaction to the wallet
  • [ ] The modal/popover includes a way to decide whether all orders on the market will also be cancelled when closing the position

barnabee avatar Jul 05 '24 16:07 barnabee