frontend-monorepo icon indicating copy to clipboard operation
frontend-monorepo copied to clipboard

Last 4 game results does not include games where a team scored nothing

Open barnabee opened this issue 10 months ago • 3 comments

Description

I'd expect the last 4 game results here to be something like "DNF, 3rd, DNF, DNF" (or DNP–did not play?) but actually it looks like this team always does great, showing "3rd, 1st, 1st, 1st". Probably an artefact of the fact that an ineligible (zero scoring) team isn't included in the results API, but given we have epoch numbers it's possible to figure which epochs a team scored zero for.

image

Acceptance Criteria

  • [ ]

barnabee avatar Apr 01 '24 13:04 barnabee

There was some discussion with Core about whether the API should be outputting a value in the API for every epoch in which a team was eligible for a game even if they scored zero which would help with this a bit.

The FE could in theory yes fill in any blank epochs with zero scores too / instead ... since there may be epochs where the team wasnt eligible.

I guess one question I would have is are we questioning the table of scores or are we questioning the "Last 4 game results" mini-feature?

I am not sure I see the value in dumping out a full table row for every game they scored zero in, that is just going to create hundreds of rows very quickly and make it harder to see their actual placements.

I could see more value (and its an easier fix) to just include some code in the top "last 5" feature ... although there's still some potentially nasty logic in there .. I guess you'd need to:

  • Work out which games were running in the last epoch
  • If placed show it
  • If not placed show DNF for any games active
  • Look back another epoch
  • Repeat until you get to 5 games

it still gets prety nasty pretty fast if for instance there are 7 active games currently ... then basically even if you won 1 of the 7 you might still see DNF x 5 in your list depending on how we've sorted them.

JonRay15 avatar Apr 02 '24 14:04 JonRay15

Another quick solution would be to change the label to "Last 5 paid finishes" and be done with it!

JonRay15 avatar Apr 02 '24 14:04 JonRay15

Personally I am not sure the "last N [game] results" feature is useful unless there's an overall leaderboard acrolss all games per epoch, e.g. based on rewards earned for games that epoch. I thought this might exist given the competitions homepage is similar but over the last ~month, though…

In that case, saying your recent performance history across all games is 1st, 3rd, DNF, 8th, 2nd (or whatever) makes sense to me. Otherwise I'd probably ditch it unless there's a very clear relabelling, so that it's not confusing or difficult to understand for a casual user.

barnabee avatar May 29 '24 10:05 barnabee