frontend-monorepo icon indicating copy to clipboard operation
frontend-monorepo copied to clipboard

Update TradingView default colours to match Vega

Open JonRay15 opened this issue 11 months ago • 1 comments

The Chore

The fact TV chart has diff reds and greens to the rest of the page is jarring to me ...

image

Joelle says these are the colours for the order book are these ... I think we should set the default TV colour scheme to this ... ppl can always adjust it if they want to. Or we could add a preset for "Vega Colours" vs "TradingView Colours" maybe?

image

This is configured with these manually

Image

Acceptance criteria

Default colour changes

  • [ ] Dark mode

    • [ ] Canvas to #05060c
    • [ ] Green candle & order book text to #01C566
    • [ ] Red candle & order book text to #B3002E
    • [ ] Green depth chart & volume study to #012915
    • [ ] Red depth chart & volume study to #2F000C
  • [ ] Light mode

    • [ ] Canvas to ??
    • [ ] Green candle & order book text to ??
    • [ ] Red candle & order book text to ??
    • [ ] Green depth chart & volume study to ??
    • [ ] Red depth chart & volume study to ??

(Joelle gave me the dark dark mode colours but presumably you must be able to see the light mode equivalents so can you just set them please?!)

Other requirements

  • [ ] Users should still be able to change their own colours and this should be saved to local storage
  • [ ] Local storage must persist both light and dark mode settings and apply them appropriately

Additional details / background info

Example of TV light / dark issue

image

Other settings

We debated whether we wanted to canvas to match the background colour or the header colour....

The header on dark mode is #17191e ... on here I've gone wiht the canvas colour of #05060c... but if people want to debate they can ... there was even talk of doing a gradient between the two ... which to me is excessive ... but YOLO 😂

JonRay15 avatar Mar 06 '24 12:03 JonRay15