frontend-monorepo icon indicating copy to clipboard operation
frontend-monorepo copied to clipboard

feat(#1853): ledger entries date filtering

Open MadalinaRaicu opened this issue 2 years ago â€ĸ 7 comments

Related issues 🔗

Closes #1853

Description ℹī¸

Add date range filter and update ledger entries on update.

Demo đŸ“ē

image

Technical 👨‍🔧

Details of technical implementation that reviewers may need to be aware of, if applicable.

MadalinaRaicu avatar Nov 29 '22 22:11 MadalinaRaicu

Deploy Preview for vega-trading-app ready!

Name Link
Latest commit 54fc56bd1c9852046128f71b242fb04bd7146001
Latest deploy log https://app.netlify.com/sites/vega-trading-app/deploys/639363944f7fd50009af5eb6
Deploy Preview https://deploy-preview-2267--vega-trading-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Nov 29 '22 22:11 netlify[bot]

Deploy Preview for vega-ui-toolkit processing.

Name Link
Latest commit 54fc56bd1c9852046128f71b242fb04bd7146001
Latest deploy log https://app.netlify.com/sites/vega-ui-toolkit/deploys/63936394d11bfd00088a883a

netlify[bot] avatar Nov 29 '22 22:11 netlify[bot]

Deploy Preview for liquidity-provision-dashboard canceled.

Name Link
Latest commit 54fc56bd1c9852046128f71b242fb04bd7146001
Latest deploy log https://app.netlify.com/sites/liquidity-provision-dashboard/deploys/639363948ba7f90009da66bc

netlify[bot] avatar Nov 29 '22 22:11 netlify[bot]

Deploy Preview for market-depth processing.

Name Link
Latest commit 54fc56bd1c9852046128f71b242fb04bd7146001
Latest deploy log https://app.netlify.com/sites/market-depth/deploys/639363944863ab0008dea3bb

netlify[bot] avatar Nov 29 '22 22:11 netlify[bot]

Deploy Preview for vega-tools canceled.

Name Link
Latest commit 54fc56bd1c9852046128f71b242fb04bd7146001
Latest deploy log https://app.netlify.com/sites/vega-tools/deploys/639363948ba7f90009da66ba

netlify[bot] avatar Nov 29 '22 22:11 netlify[bot]



Test summary

116 â€ĸ 0 â€ĸ 2 â€ĸ 0


Run details

Project frontend-monorepo
Status Passed
Commit c7588e89d4 ℹī¸
Started Dec 9, 2022 4:40 PM
Ended Dec 9, 2022 4:47 PM
Duration 06:50 💡
OS Linux Ubuntu -
Browser Chrome 108

View run in Cypress Dashboard ➡ī¸


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Nov 29 '22 22:11 cypress[bot]

Everytime the filter changes the fetch request for ledger entries is made twice. I've also left some further comments

Screenshot 2022-12-01 at 15 55 37 Screenshot 2022-12-01 at 15 55 29

thank you @bglownia for fixing the double fetch request

MadalinaRaicu avatar Dec 09 '22 14:12 MadalinaRaicu