frontend-monorepo icon indicating copy to clipboard operation
frontend-monorepo copied to clipboard

Link to markets in listing to Console's liquidity view for secondary information

Open pennyandrews opened this issue 2 years ago • 2 comments

Story

As a potential Liquidity Provider I want to be able to see the current spread of liquidity, fee levels, margin requirement and LP share for a specific market listed in the dashboard So that I can understand the spread of liquidity provided right now and where I might fit in

Acceptance Criteria

  • [ ] I can see some sort of visual indication that it is possible to click on a market listed in the dashboard to see further details
  • [ ] When I click on a row for a market listed in the dashboard, I am taken to the Console Market Liquidity view for that market
  • [ ] The Console Market Liquidity view opens in a new tab
  • [ ] The Console Market Liquidity view that opens needs to be relative to the network you are viewing in the dashboard i.e. If you're on Fairground testnet then the link needs to take you to Console on Fairground testnet, if you are on mainnet then the link needs to take you to Console on mainnet*

*This A/C needs some discussion as we haven't implemented the network switcher yet for LP dashboard AND Console isn't currently available on mainnet as trading hasn't been enabled yet.

So we may need to kick this A/C into its own ticket or add it to the existing Network switcher ticket. However, I wanted to include it so that we are thinking about it when we investigate the technical implementation.

Tasks

  • [ ] Investigate options for how we can achieve this linking to Console's Market Liquidity view for each market we list in the dashboard
  • [ ] Discuss and agree approach with the team and stakeholder group
  • [ ] Implement
  • [ ] Test

Additional details / background info

This is an example Liquidity page for a market in Console https://console.fairground.wtf/#/liquidity/acff1b95980c3355e65c7162c35917388702525c0475ba753f03d0efc9c6d6a3

Screenshot 2022-11-22 at 10 09 24

In case you need to go and find more examples, you can get to this view from the market view here:

Screenshot 2022-11-22 at 10 00 18

pennyandrews avatar Nov 22 '22 10:11 pennyandrews

For network switching, I manually changed the network config locally for the lp-dashboard build to stagnet3 and verified that the link generated was stagnet 3 and the correct market id.

I think once we implement a switcher this should 'just work' 🤞

The rest can be verified on this preview deploy: https://deploy-preview-2225--liquidity-provision-dashboard.netlify.app/

Though I'm not sure we're achieving this criteria:

I can see some sort of visual indication that it is possible to click on a market listed in the dashboard to see further details

ciaran- avatar Nov 29 '22 15:11 ciaran-

This shipped on thursday: https://github.com/vegaprotocol/frontend-monorepo/pull/2225

ciaran- avatar Dec 06 '22 09:12 ciaran-