voyager icon indicating copy to clipboard operation
voyager copied to clipboard

Upgraded to [email protected], [email protected], [email protected], [email protected]

Open siyaoL1 opened this issue 3 years ago • 11 comments

List of upgraded dependencies:

  • ajv
  • vega
  • vega-lite
  • compassql
  • vega-datasets
  • vega-expression
  • vega-tooltip
  • vega-typings
  • vega-util
  • vega-functions
  • css-loader
  • extract-text-webpack-plugin
  • file-loader
  • html-webpack-plugin
  • postcss-loader
  • react-dnd
  • react-dev-utils
  • react-hot-loader
  • sass-loader
  • source-map-loader
  • terser-webpack-plugin
  • ts-jest
  • ts-loader
  • typescript
  • url-loader
  • webpack
  • webpack-cli
  • webpack-dev-server
  • webpack-manifest-plugin
  • @types/webpack
  • @types/node
  • @types/react

siyaoL1 avatar Apr 06 '22 19:04 siyaoL1

This pull request introduces 3 alerts when merging 320bc0410a184bec2f9717bb4a54a88446df7f83 into 882809fb2aafdec1d967505a7c41efc9b78b021f - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Unreachable statement

lgtm-com[bot] avatar Apr 06 '22 20:04 lgtm-com[bot]

I will work on addressing the comments

siyaoL1 avatar Apr 07 '22 21:04 siyaoL1

This pull request introduces 3 alerts when merging 8822adffc3ce0631beab3e328e7362aae31f50fe into 882809fb2aafdec1d967505a7c41efc9b78b021f - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Unreachable statement

lgtm-com[bot] avatar Apr 20 '22 19:04 lgtm-com[bot]

This pull request introduces 2 alerts when merging d86b3e79a62ff36e1fa22a0a83c42b2a18c8b7e5 into 882809fb2aafdec1d967505a7c41efc9b78b021f - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

lgtm-com[bot] avatar Apr 26 '22 23:04 lgtm-com[bot]

This pull request introduces 2 alerts when merging 40bec63c67c4de5d82ebc7b07a4b1a7aad009fae into 882809fb2aafdec1d967505a7c41efc9b78b021f - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

lgtm-com[bot] avatar Apr 26 '22 23:04 lgtm-com[bot]

Please fix the tests

domoritz avatar Apr 29 '22 19:04 domoritz

This pull request introduces 2 alerts when merging 6d04f8455877a2702d2ba530f7c9ee0204c43493 into 2bd9d86efc7ed312d54d4ae5c390cbf05d75cbde - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

lgtm-com[bot] avatar May 25 '22 21:05 lgtm-com[bot]

Let me know when tests pass.

domoritz avatar May 27 '22 01:05 domoritz

Thanks! I just addressed the comments and deleted the unavailable datasets, and I have tested that the app works as expected. Would you like me to add more datasets from vega-datasets?

siyaoL1 avatar Jun 01 '22 03:06 siyaoL1

@siyaoL1 is working on support CSV and then we can merge this.

domoritz avatar Jun 05 '22 16:06 domoritz

This pull request introduces 1 alert when merging 0bd2706fd2f568956ccd1932b597d2dd9042e1d9 into 2bd9d86efc7ed312d54d4ae5c390cbf05d75cbde - view on LGTM.com

new alerts:

  • 1 for Incomplete multi-character sanitization

lgtm-com[bot] avatar Jun 08 '22 05:06 lgtm-com[bot]