voyager icon indicating copy to clipboard operation
voyager copied to clipboard

Add prefix to all CSS classes to help embedding

Open ellisonbg opened this issue 8 years ago • 1 comments

Right now there are lots of fairly generic CSS classes such as .card that have no prefix. This is going to make it difficult to embed voyager on other sites. Thinking about JupyterLab, it would be great if all the CSS classes in voyager had a common prefix. Alternatively, having a CSS class on all the top level components (encoding, data viz) such as .voyager and then using child selectors everywhere would be another way of making the CSS more embedding friendly.

ellisonbg avatar Jul 08 '17 21:07 ellisonbg

Alternatively, having a CSS class on all the top level components (encoding, data viz) such as .voyager and then using child selectors everywhere would be another way of making the CSS more embedding friendly.

We have .voyager for generic css classes and generate other component based css class using react-css-modules, which automatically add prefix and thus would avoid name collision.

We could add a special voyager prefix to the build version.

kanitw avatar Aug 08 '17 22:08 kanitw