vega icon indicating copy to clipboard operation
vega copied to clipboard

feat: add field predicate types to selectionTest in vega-selections

Open jonathanzong opened this issue 2 years ago • 6 comments

This change introduces the ability for vlSelectionTest to check for more types of field predicates.

This additive change will have no immediate effect, since Vega-Lite doesn't currently produce selection tuples that use these predicate types. However, future proposed changes for Animated Vega-Lite will require us to support these field predicates in addition to the existing point and interval predicates.

cc @arvind

jonathanzong avatar Mar 03 '23 04:03 jonathanzong

i believe this supersedes https://github.com/vega/vega/pull/1839 which is also very stale anyway

jonathanzong avatar Mar 03 '23 05:03 jonathanzong

bump @arvind

jonathanzong avatar Sep 25 '23 19:09 jonathanzong

@arvind can you wrap up the review and merge if it looks good?

domoritz avatar Mar 12 '24 16:03 domoritz

I found a potential problem here: ops in selectionResolve do a lookup with the first letter of the type name, which is assumed to be E or R. Since we are introducing new types here the lookup seem like they will fail if you try to use them.

I'm pretty confused but can look into this later but let's not merge this yet until then.

jonathanzong avatar Jun 04 '24 22:06 jonathanzong

I converted this pull request to a draft. Please mark it as ready.

domoritz avatar Jun 10 '24 02:06 domoritz