vega-lite icon indicating copy to clipboard operation
vega-lite copied to clipboard

Published 20 hours ago • verified publisher icon vega

Format CI does not work on forked repositories

Open lsh opened this issue 2 years ago • 4 comments

It seems that forked repositories do not work even when using the GitHub Secret as mentioned in the docs. This causes friction with contribution PRs as seen in #8282, #8302, and #8303.

lsh avatar Jul 29 '22 18:07 lsh

cc @domoritz

lsh avatar Jul 29 '22 18:07 lsh

Hmm, I didn't test this properly it seems. Did you look into how we may be able to fix it?

domoritz avatar Jul 29 '22 19:07 domoritz

@jonmmease suggested adding pull_request to checks.yml as a possible solution.

lsh avatar Jul 29 '22 20:07 lsh

Iirc that caused us to have to builds for internal prs. But things may have changed.

domoritz avatar Jul 29 '22 23:07 domoritz

@lsh are you looking into this issue?

domoritz avatar Aug 11 '22 22:08 domoritz

I haven't had a chance to take a crack at it but I can probably take a look tomorrow

lsh avatar Aug 12 '22 01:08 lsh

Ah I remember the difficulty. We need to push to the branch after our check script and win a pull request trigger the target branch is not the right branch. So keep that in mind as you experiment.

domoritz avatar Aug 12 '22 14:08 domoritz

:rocket: Issue was released in v5.5.0 :rocket:

vega-org-bot avatar Aug 15 '22 20:08 vega-org-bot