vega-lite icon indicating copy to clipboard operation
vega-lite copied to clipboard

Published 20 hours ago • verified publisher icon vega

feat: Lasso Specification Compiler

Open dvmoritzschoefl opened this issue 2 years ago • 2 comments

This is the vega-lite implementation for lasso selections. It is compatible with the current vega master branch.

dvmoritzschoefl avatar Apr 15 '22 12:04 dvmoritzschoefl

@arvind I added runtime and compile tests for the lasso selection. I also refactored lasso to region in the comments and classes.

dvmoritzschoefl avatar Jul 10 '22 16:07 dvmoritzschoefl

Thanks for the contribution. (Sorry for the super delayed review)

It seems like something is wrong with the generated PNGs?

image

This seems to be the incorrect location anyway for the images. I think I generated them in the wrong place once and did not notice, the only place where those are generated is by running the runtime tests right? (Then I can just delete them and it run it again)

dvmoritzschoefl avatar Sep 12 '22 05:09 dvmoritzschoefl

Closing this in favor of #8988 which freshens the code, expands runtime test coverage, and fixes a few bugs along the way.

THANK YOU @dvmoritzschoefl for all your contributions here, and I'm very sorry it's taken us such a long time to actually make progress on getting it merged.

arvind avatar Jul 07 '23 17:07 arvind