lyra icon indicating copy to clipboard operation
lyra copied to clipboard

Windows close doesn't work in electron

Open davidanthoff opened this issue 4 years ago • 1 comments

I'm running the lyra2019 branch in an electron window and it works great. But if I click on the close button of the electron window, nothing happens, in particular, the window doesn't close.

Does lyra somehow hook into some close event and prevents closing from happening?

davidanthoff avatar Mar 15 '20 01:03 davidanthoff

here's the problem line -- i recommend commenting it out for now to get your things working, and i think there can be a separate conversation later about whether this is useful for lyra

https://github.com/vega/lyra/blob/58b2029c684649ba26e4bbb2801da893044ace41/src/js/ctrl/listeners.ts#L41

jonathanzong avatar Mar 30 '20 01:03 jonathanzong