phylotree.js icon indicating copy to clipboard operation
phylotree.js copied to clipboard

Newick files without lengths should not be coerced to distances of 1

Open gaurav opened this issue 1 year ago • 1 comments

In previous versions of phylotree.js, a Newick file without lengths was read as a Newick file without length. In the current version of phylotree.js, a Newick file without length is assumed to have a length of 1 at each edge. This is annoying in two ways:

  1. Phylogenies are incorrectly drawn to appear as if the length is 1, which could be misleading.
  2. It makes it harder for phylotree.js to be used in a phylogeny editor (as described in https://github.com/veg/phylotree.js/issues/438#issue-1852706062), since the Newick produced by a Phylotree instance isn't identical to the Newick passed to it.

Would it be possible to have an option for turning this off?

gaurav avatar Aug 30 '23 04:08 gaurav

Dear @gaurav,

Yes, I think having an option to turn that off is a good idea.

Best, Steven

stevenweaver avatar Sep 07 '23 15:09 stevenweaver