hudhook icon indicating copy to clipboard operation
hudhook copied to clipboard

Bugfix panic in D3D11RenderEngine->restore

Open FrankvdStam opened this issue 1 year ago • 2 comments

When self.ps_instances is none, self.ps_instances_count is 0, then slice::from_raw_parts causes a panic here. Same for the vs version. Initially I tried this fix with is_some() but it still caused a crash for me.

I don't know if this has any side effects, for me it renders fine after this fix.

FrankvdStam avatar Apr 28 '24 08:04 FrankvdStam

Committed your suggestion and did the same bellow, plus fixed the linting error, tested and it works on remastered.

FrankvdStam avatar Apr 28 '24 11:04 FrankvdStam

Oh, right, CI fails because of the new transmute lint. I'll fix that first and then merge this one, shouldn't need a rebase hopefully.

veeenu avatar Apr 29 '24 14:04 veeenu

This change is so small, I don't think there will be any issues merging

FrankvdStam avatar Apr 30 '24 07:04 FrankvdStam