winget-releaser icon indicating copy to clipboard operation
winget-releaser copied to clipboard

[Bug]: Status 500: RequestError [HttpError]: other side closed

Open Gedochao opened this issue 1 year ago • 5 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

What happened?

What's happening

We are getting RequestError [HttpError] when releasing Scala CLI on winget with the winget-releaser action.

RequestError [HttpError]: other side closed
    at D:\a\_actions\vedantmgoyal2009\winget-releaser\v2\dist\index.js:6964:11
    at async D:\a\_actions\vedantmgoyal2009\winget-releaser\v2\dist\index.js:30094:27 {
  status: 500,
  request: {
    method: 'GET',
    url: 'https://api.github.com/repos/microsoft/winget-pkgs/contents/manifests%2Fv%2FVirtusLab%2FScalaCLI',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit-core.js/5.0.1 Node.js/20.8.1 (win32; x64)',
      authorization: 'token [REDACTED]'
    },
    request: {
      agent: Agent {
        _events: [Object: null prototype] {
          free: [Function (anonymous)],
          newListener: [Function: maybeEnableKeylog]
        },
        _eventsCount: 2,
        _maxListeners: undefined,
        defaultPort: 443,
        protocol: 'https:',
        options: [Object: null prototype] {
          keepAlive: true,
          scheduling: 'lifo',
          timeout: 5000,
          noDelay: true,
          path: null
        },
        requests: [Object: null prototype] {},
        sockets: [Object: null prototype] {},
        freeSockets: [Object: null prototype] {},
        keepAliveMsecs: 1000,
        keepAlive: true,
        maxSockets: Infinity,
        maxFreeSockets: 256,
        scheduling: 'lifo',
        maxTotalSockets: Infinity,
        totalSocketCount: 0,
        maxCachedSessions: 100,
        _sessionCache: { map: {}, list: [] },
        [Symbol(kCapture)]: false
      },
      fetch: [Function: proxyFetch],
      hook: [Function: bound bound register]
    }
  }
}

We got this error on 2 subsequent releases up till now (details below).

Scala CLI tags on which it failed and the related winget-pckgs PRs

  • https://github.com/VirtusLab/scala-cli/tree/v1.1.2 - Scala CLI v1.1.2 tag: winget release failed with the error above, PR to winget-pckgs got created, it's still hanging
    • the winget-pckgs PR: https://github.com/microsoft/winget-pkgs/pull/135148
  • https://github.com/VirtusLab/scala-cli/tree/v1.1.1 - Scala CLI v1.1.1 tag, winget release failed with the error above, PR to winget-pckgs got created and then merged, seems to have been a false positive as v1.1.1 is available on winget
    • the winget-pckgs PR: https://github.com/microsoft/winget-pkgs/pull/133549
  • v1.1.0 and earlier releases have been green, so the issue started appearing with v1.1.1

Extra context

  • https://github.com/VirtusLab/scala-cli/issues/2689 - corresponding Scala CLI issue

Gedochao avatar Jan 24 '24 12:01 Gedochao

Here's how we use the winget-releaser action in our workflow: https://github.com/VirtusLab/scala-cli/blob/0421cd92116c6276ca658680e172bae255fd95c4/.github/workflows/ci.yml#L1266-L1271

Gedochao avatar Jan 24 '24 12:01 Gedochao

We're seeing this as well with the Databricks CLI: https://github.com/databricks/cli/blob/main/.github/workflows/release.yml#L121-L131.

Is this a problem from Cleaning up previous stale branches of merged pull requests on the fork or Check for versions w.r.t. max-versions-to-keep? It's hard to tell from the error message.

mgyucht avatar Feb 21 '24 15:02 mgyucht

https://github.com/VirtusLab/scala-cli/issues/2689#issuecomment-1983325033 Interestingly, this seems to have fixed itself during our recent release. Was any work done? Can anyone confirm this is fixed?

Gedochao avatar Mar 07 '24 11:03 Gedochao

I can confirm the issue in the today's release of Sandboxie Plus: https://github.com/sandboxie-plus/Sandboxie/actions/runs/8425847760/job/23072858860#step:2:89

RequestError [HttpError]: other side closed
RequestError [HttpError]: other side closed
    at D:\a\_actions\vedantmgoyal2009\winget-releaser\v2\dist\index.js:6964:11
    at async D:\a\_actions\vedantmgoyal2009\winget-releaser\v2\dist\index.js:30094:27 {
  status: 500,
  request: {
    method: 'GET',
    url: 'https://api.github.com/repos/microsoft/winget-pkgs/contents/manifests%2Fs%2FSandboxie%2FPlus',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit-core.js/5.0.1 Node.js/20.8.1 (win32; x64)',
      authorization: 'token [REDACTED]'
    },
    request: {
      agent: Agent {
        _events: [Object: null prototype] {
          free: [Function (anonymous)],
          newListener: [Function: maybeEnableKeylog]
        },
        _eventsCount: 2,
        _maxListeners: undefined,
        defaultPort: 443,
        protocol: 'https:',
        options: [Object: null prototype] {
          keepAlive: true,
          scheduling: 'lifo',
          timeout: 5000,
          noDelay: true,
          path: null
        },
        requests: [Object: null prototype] {},
        sockets: [Object: null prototype] {},
        freeSockets: [Object: null prototype] {},
        keepAliveMsecs: 1000,
        keepAlive: true,
        maxSockets: Infinity,
        maxFreeSockets: 256,
        scheduling: 'lifo',
        maxTotalSockets: Infinity,
        totalSocketCount: 0,
        maxCachedSessions: 100,
        _sessionCache: { map: {}, list: [] },
        [Symbol(kCapture)]: false
      },
      fetch: [Function: proxyFetch],
      hook: [Function: bound bound register]
    }
  }
}

isaak654 avatar Mar 25 '24 22:03 isaak654

Same on todays release of Strem https://github.com/strem-app/strem/actions/runs/8520086677/job/23335563086

RequestError [HttpError]: other side closed
    at D:\a\_actions\vedantmgoyal2009\winget-releaser\v2\dist\index.js:6964:11
    at async D:\a\_actions\vedantmgoyal2009\winget-releaser\v2\dist\index.js:30094:27 {
  status: 500,
  request: {
    method: 'GET',
    url: 'https://api.github.com/repos/microsoft/winget-pkgs/contents/manifests%2Fs%2FSandboxie%2FPlus',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit-core.js/5.0.1 Node.js/20.8.1 (win32; x64)',
      authorization: 'token [REDACTED]'
    },
    request: {
      agent: Agent {
        _events: [Object: null prototype] {
          free: [Function (anonymous)],
          newListener: [Function: maybeEnableKeylog]
        },
        _eventsCount: 2,
        _maxListeners: undefined,
        defaultPort: 443,
        protocol: 'https:',
        options: [Object: null prototype] {
          keepAlive: true,
          scheduling: 'lifo',
          timeout: 5000,
          noDelay: true,
          path: null
        },
        requests: [Object: null prototype] {},
        sockets: [Object: null prototype] {},
        freeSockets: [Object: null prototype] {},
        keepAliveMsecs: [100](https://github.com/sandboxie-plus/Sandboxie/actions/runs/8425847760/job/23072858860#step:2:103)0,
        keepAlive: true,
        maxSockets: Infinity,
        maxFreeSockets: 256,
        scheduling: 'lifo',
        maxTotalSockets: Infinity,
        totalSocketCount: 0,
        maxCachedSessions: 100,
        _sessionCache: { map: {}, list: [] },
        [Symbol(kCapture)]: false
      },
      fetch: [Function: proxyFetch],
      hook: [Function: bound bound register]
    }
  }
}

grofit avatar Apr 02 '24 09:04 grofit

Is there any update about this bug?

OpenWaygate avatar Jun 08 '24 08:06 OpenWaygate

This has been fixed in vedantmgoyal9/winget-releaser@main.

vedantmgoyal9 avatar Jun 25 '24 05:06 vedantmgoyal9

This has been fixed in vedantmgoyal9/winget-releaser@main.

Is uses: vedantmgoyal9/winget-releaser@v2 still valid in our workflow?

isaak654 avatar Jun 25 '24 12:06 isaak654

@isaak654 the new changes are only available on vedantmgoyal9/winget-releaser@main. The v2 will still work, but it won't include the newest changes.

vedantmgoyal9 avatar Jun 25 '24 17:06 vedantmgoyal9

@allcontributors please add @Gedochao for bug. please add @mgyucht for bug. please add @grofit for bug. please add @OpenWaygate for bug.

vedantmgoyal9 avatar Jun 28 '24 06:06 vedantmgoyal9

@vedantmgoyal9

@grofit already contributed before to bug

allcontributors[bot] avatar Jun 28 '24 11:06 allcontributors[bot]

@vedantmgoyal9

I've put up a pull request to add @OpenWaygate! :tada:

allcontributors[bot] avatar Jun 28 '24 11:06 allcontributors[bot]