pdf-tools icon indicating copy to clipboard operation
pdf-tools copied to clipboard

Use nix-shell on macOS if available in auto builds script

Open shaunsingh opened this issue 4 years ago • 7 comments

(putting it here because I think this is the pdf-tools repo doom/melpa uses)

I use both homebrew and nix on my Mac, I use nix for most packages and brew only for its cask functionality. This adds nix support on Mac, and prioritizes it over homebrew

Tested on my m1 MacBook, emacs29, via pdf-tools-install: image

Not sure why the CI is failing, this shouldn't affect anything on linux.

Fixes: https://github.com/politza/pdf-tools/issues/690

shaunsingh avatar Oct 26 '21 19:10 shaunsingh

Hey @shaunsingh ,

The CI is failing because you have committed this on top of politza/master, instead of on top of vedang/master. Can you please rebase your master branch to vedang/master and then submit the PR again? Also, review the comment I've left on the commit.

vedang avatar Nov 10 '21 05:11 vedang

Sorry about that, will fix

shaunsingh avatar Dec 01 '21 17:12 shaunsingh

Removing this from the v1.0.0 milestone, since there has been no activity on it.

vedang avatar Oct 03 '22 11:10 vedang

What is necessary to finish this task? I am super interested

danilevy1212 avatar Oct 03 '22 15:10 danilevy1212

@danilevy1212 :

  1. Rebase the patch-set on top of the latest master.
  2. Make code changes as described in the review
  3. Run tests to ensure everything is working, as described in https://pdftools.wiki/fd64c10c
  4. Optionally, and huge contribution if you can, modify the CI/CD setup to work on MacOS and add a way to test this automatically.

Step 4 above is involved and therefore optional. The other three should be relatively straightforward.

vedang avatar Oct 03 '22 16:10 vedang

Thank you! Hopefully I manage to get some time over the next few weekends

danilevy1212 avatar Oct 03 '22 17:10 danilevy1212

I'm not going to be using MacOS soon, so I will probably won't be able to get around to do this.

danilevy1212 avatar Nov 25 '22 22:11 danilevy1212

I have no idea why / how this was closed. Re-opening it, since it hasn't been merged in.

vedang avatar Mar 14 '24 14:03 vedang

??

vedang avatar Mar 14 '24 14:03 vedang