pdf-tools icon indicating copy to clipboard operation
pdf-tools copied to clipboard

Add keyboard navigation minor mode

Open orgtre opened this issue 2 years ago • 7 comments

Introduces standard-Emacs-like concepts of point, mark, region, and cursor into pdf-tools and uses these to implement keyboard-based navigation, selection, and annotation in pdf files.

orgtre avatar Aug 17 '21 11:08 orgtre

This is brilliant and really well-thought out! It is of course annoying that navigation (especially character-by-character with C-f etc.) feels slow, but otherwise this does really allow a totally keyboard-centric usage of pdf-tools.

I did some cleanup of the code here: https://github.com/orgtre/pdf-tools/pull/2

andersjohansson avatar Nov 29 '21 16:11 andersjohansson

Thanks! I merged the cleanup. The only way I can come up with to make it faster is to co-opt the mouse pointer as cursor. This has some obvious drawbacks as that's not what the mouse pointer is for and I've not managed to work the positioning out properly yet, but a proof-of-concept is in the "pointer-as-cursor" branch. Any other ideas are welcome.

orgtre avatar Dec 01 '21 00:12 orgtre

This is great @orgtre! This particular feature has been on my todo list for a while. Sorry for ignoring the PR for a bit, but I plan to review the code and test it out over the weekend. I'll get back with thoughts and feedback (if any) in the next week.

vedang avatar Dec 30 '21 15:12 vedang

I am picking up the review of this giant set of changes this week, looking forward to finally testing it out. Where possible, I will squash / update the commits myself instead of getting back with review comments -- because this is such a big change across so many commits.

I'll get back here with questions / doubts, if any. Thank you!

vedang avatar Jan 17 '23 06:01 vedang

Wow great! Feel free to do what you want. Let me know if there is anything I can do. Thanks for your work (the last 8 hours were huge for pdf tools)!

orgtre avatar Jan 17 '23 09:01 orgtre

Has there been any progress on this?

asymmetric avatar Apr 15 '23 15:04 asymmetric

No, unfortunately I have not been able to make the time.

This is a really big change and needs some careful focus. I have a week set aside in May (8th to 12th May) where I am on vacation from my day job and have time to work on pdf-tools. This is the first PR I plan to work on in that time.

On Sat, Apr 15, 2023 at 8:38 PM asymmetric @.***> wrote:

Has there been any progress on this?

— Reply to this email directly, view it on GitHub https://github.com/vedang/pdf-tools/pull/39#issuecomment-1509867340, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUUHWWE2WP4XVE6VNWDWDXBK2WVANCNFSM5CJWMHDA . You are receiving this because you commented.Message ID: @.***>

-- Cheers, Vedang

https://vedang.me @vedang on Twitter

vedang avatar Apr 16 '23 05:04 vedang