pdf-view-midnight-minor-mode not persistent

[sati-bodhi]

trafficstars

Describe the bug A clear and concise description of what the bug is.

midnight-minor-mode fails to retain its effect on the buffer after annotations are saved or deleted.

Steps to Reproduce the behaviour Steps to reproduce the behaviour:

1. Enable midnight-minor-mode
2. Add highlight annotation.
3. Save buffer.
4. Delete annotation.
5. midnight-minor-mode loses effect on the buffer.
6. Disable midnight-minor-mode
7. Enable midnight-minor-mode

Steps 6 and 7 are required to bring back the dark mode.

What is the expected behaviour? A clear and concise description of what you expected to happen.

midnight-minor-mode should persist in a single session until the user toggles it.

Desktop Please complete the following information:

• OS: Ubuntu 22.04
• Emacs Version: GNU Emacs 28.2 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2022-12-09
• Poppler Version: pdftocairo version 22.02.0

Your pdf-tools install Please complete the following information:

• pdf-tools Version: Not available in Doom.
• pdf-tools customization / configuration that you use

Default.

Additional context

• If you are reporting a crash, please try and add the Backtrace / Stacktrace of the crash.
• If you are reporting a bug, please try and attach an example PDF file where I can reproduce the bug.
• If you can attach screenshots or recordings, that is a great help
• Please try reproducing the bug yourself on Vanilla Emacs before reporting the problem.

[vedang]

I've added the waiting label here because I cannot reproduce this issue on my setup. I will add instructions on how to test pdf-tools under Vanilla Emacs so that you can try that out and see if the bug persists.

In the meantime, if you know how to install packages on Vanilla Emacs, please test the behaviour and let me know as well!