Cabinets do not extend barrels

[Violet-Scarelli]

As the title says. This is a rather esoteric issue, but cabinets having their own unique code (instead of extending barrels) prevents them from being used as containers on Create contraptions, as well as being used by Botania's Corporea network. I'm not sure how trivial or difficult such a change would be, but making cabinets extend barrels would be extremely helpful.

[MehVahdJukaar]

i think actual issue is that they dont provider item handler capability. In 1.21 one needs to manually register those as they are not gotten through inheritancy. extending wout both be incorrect, as cabinets are not barrel, nor solve the issue

[vectorwing]

I ran a quick test on this for both 1.20.1 and 1.21, and yeah, both versions seem affected by this.

While the 1.21 change makes sense, and requires me to implement it through a NeoForge event, I am unsure why it's not working on 1.20.1 yet. It uses the same overrides as BarrelBlockEntity, and both get properly cast to a common item handler, according to my breakpoints. 🤔

Not sure what to do about 1.20 yet, but at least I can test out a fix on 1.21 later.

[cassiancc]

Create's modded support requires the block to have "barrel" or "chest" in the name for it to work, (see MountedStorage.java). Raspberry Flavoured will have a fix for this in its next release by injecting into Create to allow Cabinets to pass in the same way that Barrels are allowed. Obviously, this isn't the best solution for compatibility, but it does solve the issue for us.

[vectorwing]

Huh, interesting way of approaching this! 😄 I suppose it isn't FD's fault in this case, as I can't do much to fix it. I'll keep an eye on Create and see if they ever introduce a tag or similar to allow other containers to be mounted on contraptions.