vector icon indicating copy to clipboard operation
vector copied to clipboard
verified publisher icon vectordotdev

fix(websocket source): reconnect indefinitely when connection fails

Open benjamin-awd opened this issue 2 months ago • 1 comments

Summary

This PR fixes Vector entering a "zombie" state when the connect_timeout_secs threshold is reached with multiple sources running at the same time. The previous behavior was to retry until connect_timeout_secs runs out, but it probably makes more sense to apply the connect timeout per connect attempt and retry indefinitely.

How did you test this PR?

Tested using example from #23992

Change Type

  • [x] Bug fix
  • [ ] New feature
  • [ ] Non-functional (chore, refactoring, docs)
  • [ ] Performance

Is this a breaking change?

  • [ ] Yes
  • [x] No

Does this PR include user facing changes?

  • [x] Yes. Please add a changelog fragment based on our guidelines.
  • [ ] No. A maintainer will apply the no-changelog label to this PR.

References

Closes #23992

benjamin-awd avatar Oct 24 '25 16:10 benjamin-awd

Hi @benjamin-awd, thanks for this. Since this alters Vector's behavior and has been part of a previous release this is considered user facing and therefore needs a changelog. I'll take a look again after another commit is pushed

thomasqueirozb avatar Oct 24 '25 17:10 thomasqueirozb

Slipped through the cracks, should've merged a while ago. I'll try to queue and make necessary changes (if needed) to get this one in

thomasqueirozb avatar Dec 10 '25 18:12 thomasqueirozb