vectordotdev
chore(deps): use fasyslog for creating syslog payload
This closes https://github.com/vectordotdev/vector/pull/20955.
Somehow self-promoted and I'm actively maintaining fasyslog. I'd appreciate it if you can give a review and see whether we can go in this way.
cc @jszwedko
Hi @tisonkun, we will taking a look at this PR. Thank you for submitting this. There's a big backlog so it takes a bit longer than usual. Generally, for future PRs (and in case someone from the community reads this) please ping @vectordotdev/vector.
@pront Thanks for your information!
It seems @vectordotdev/vector is not a team? Since it's not in bold I'm not sure if the notification is sent.
BTW, could you trigger the CI workflow so that I can check if any trivial issues should be fixed?
It seems @vectordotdev/vector is not a team? Since it's not in bold I'm not sure if the notification is sent.
Interesting, thanks for letting me know:
BTW, could you trigger the CI workflow so that I can check if any trivial issues should be fixed?
Done!
Aha. I should ping @vectordotdev/vector instead.
Fix conflict. Could you retrigger the CI and review this patch?
Thank you @tisonkun, there are some new conflicts. I recommend waiting for a day before resolving this because on Mondays we update all dependencies and new conflicts might arise.
@pront Thank you! Resolved now.
Would you please trigger the CI and see when to review? Hopefully we don't need to rebase several times later.
@pront Thank you! Resolved now.
Would you please trigger the CI and see when to review? Hopefully we don't need to rebase several times later.
I highly recommend running these before pushing a new commit:
https://github.com/vectordotdev/vector/blob/47f5e4f20a192602f97eff5354b86d5029e0575c/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L51-L53
Also, did you have a chance to test the papertrail sink with your changes?
Updated.
@pront @thomasqueirozb please take a look and hopefully we can avoid further conflict.
Reminder @pront
I'd try to send reminder each week or it's likely to be stale later. If you find it too frequent, please let me know :D