vector icon indicating copy to clipboard operation
vector copied to clipboard

enhancement(kubernetes_logs): support scraping metadata from Kubernetes log files on Windows

Open damoxc opened this issue 1 year ago • 4 comments
trafficstars

This implements the changes from #19799, including the suggested fix for the failing test. I've been running the change with the path separator successfully for 5 months on Windows.

This resolves #18521.

damoxc avatar Oct 15 '24 09:10 damoxc

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Oct 15 '24 09:10 bits-bot

@jszwedko I've added a changelog entry, hopefully I got it right!

damoxc avatar Oct 16 '24 14:10 damoxc

Note that there are some compilation errors here when you have some time @damoxc

jszwedko avatar Oct 16 '24 23:10 jszwedko

Actually, it was just a missing import I think so I pushed a commit adding it.

jszwedko avatar Oct 16 '24 23:10 jszwedko

@jszwedko I've had a go at fixing the type errors in the tests, still quite new to Rust so not 100% sure if I'm doing the right thing

damoxc avatar Oct 22 '24 09:10 damoxc

@jszwedko forgot to run cargo fmt on the changes, I've just pushed another commit for that

damoxc avatar Oct 22 '24 15:10 damoxc