vector
vector copied to clipboard
vectordotdev
enhancement(build.rs) Allow reading the git short has from the build environment
Why are we doing this whole handling of the environment variable? Packagers often do not package from a git working copy? they grab a tarball and cargo vendor the dependencies and then build in an offline environment. This allows them to give the value of the hash (or an equivalent value like the tag) to the build from the build description. If that value is not in the environment, we fall through to the old code that parses the git rev-parse output.
So from all the packagers: Thank you for keeping this code alive!
Fixes #21473
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
why doesn't the main readme mention that you need a CLA to contribute?
It's mentioned in CONTRIBUTING.md: https://github.com/vectordotdev/vector/blob/master/CONTRIBUTING.md#contributor-license-agreement. I think the main README's audience is, generally, end-users.
Unfortunately, we will need to have the CLA signed for this contribution. Let us know if you have any questions about it!