vector
vector copied to clipboard
feat(watcher): add support for poll watcher
Closes https://github.com/vectordotdev/vector/issues/21111
Hey @amribm, thank you for this PR!
- This requires a changelog entry. See https://github.com/vectordotdev/vector/blob/master/changelog.d/README.md.
- I see there are a couple of open comment threads, is this ready for a review?
okay, i will add changelog
- I see there are a couple of open comment threads, is this ready for a review?
Yes This is ready for review , @pront i need some confirmation from vector team for those comments. that's why i didn't resolved them.
It seems that these comments are resolved https://github.com/vectordotdev/vector/pull/21290#discussion_r1759726163 but I dont see any documentation about this new option.
Shouldn't that be included in this PR? @pront
It seems that these comments are resolved #21290 (comment) but I dont see any documentation about this new option.
Shouldn't that be included in this PR? @pront
Let's include it in this PR 👍 cc @amribm
I think we addressed all open questions here? cc @amribm and @jorgehermo9 If so, I will go ahead and merge this one. Let me know if you need any further input from me.
LGTM!
Apologies, I didn't realize this got pushed out of the merge queue.
When this PR will merge @pront?
When this PR will merge @pront?
It looks like there were cue formatting issues blocking merge as the failed CI check shows. I formatted and pushed though so I think this should merge soon if there are no other failing checks.
Thanks again, this is a great contribution 🚀
Thank you guys, this is my first open-source contribution. thanks for making this possible. @jorgehermo9 @pront @brittonhayes