vector icon indicating copy to clipboard operation
vector copied to clipboard

feat(watcher): add support for poll watcher

Open amribm opened this issue 1 year ago • 5 comments
trafficstars

Closes https://github.com/vectordotdev/vector/issues/21111

amribm avatar Sep 13 '24 04:09 amribm

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Sep 13 '24 04:09 bits-bot

Hey @amribm, thank you for this PR!

  • This requires a changelog entry. See https://github.com/vectordotdev/vector/blob/master/changelog.d/README.md.
  • I see there are a couple of open comment threads, is this ready for a review?

pront avatar Sep 26 '24 13:09 pront

okay, i will add changelog

  • I see there are a couple of open comment threads, is this ready for a review?

Yes This is ready for review , @pront i need some confirmation from vector team for those comments. that's why i didn't resolved them.

amribm avatar Sep 26 '24 14:09 amribm

It seems that these comments are resolved https://github.com/vectordotdev/vector/pull/21290#discussion_r1759726163 but I dont see any documentation about this new option.

Shouldn't that be included in this PR? @pront

jorgehermo9 avatar Oct 10 '24 21:10 jorgehermo9

It seems that these comments are resolved #21290 (comment) but I dont see any documentation about this new option.

Shouldn't that be included in this PR? @pront

Let's include it in this PR 👍 cc @amribm

pront avatar Oct 11 '24 19:10 pront

I think we addressed all open questions here? cc @amribm and @jorgehermo9 If so, I will go ahead and merge this one. Let me know if you need any further input from me.

pront avatar Oct 22 '24 18:10 pront

LGTM!

jorgehermo9 avatar Oct 22 '24 18:10 jorgehermo9

Apologies, I didn't realize this got pushed out of the merge queue.

pront avatar Nov 06 '24 18:11 pront

When this PR will merge @pront?

amribm avatar Nov 11 '24 08:11 amribm

When this PR will merge @pront?

It looks like there were cue formatting issues blocking merge as the failed CI check shows. I formatted and pushed though so I think this should merge soon if there are no other failing checks.

jszwedko avatar Nov 11 '24 13:11 jszwedko

Thanks again, this is a great contribution 🚀

pront avatar Nov 11 '24 19:11 pront

Thank you guys, this is my first open-source contribution. thanks for making this possible. @jorgehermo9 @pront @brittonhayes

amribm avatar Nov 12 '24 04:11 amribm