vector icon indicating copy to clipboard operation
vector copied to clipboard

Published 20 hours ago • verified publisher icon vectordotdev

feat(chronicle-sink): add support for compression to Google Chronicle sink

Open ChocPanda opened this issue 1 year ago • 3 comments
trafficstars

Google Chronicle's ingestion API supports use of GZip compression - https://cloud.google.com/chronicle/docs/reference/ingestion-api#frequently_asked_questions

ChocPanda avatar Sep 11 '24 11:09 ChocPanda

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Sep 11 '24 11:09 bits-bot

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @ChocPanda, thank you for this contribution! A few comments:

  • The changes look good!
  • Please see the above.
  • Please take a look at https://github.com/vectordotdev/vector/blob/master/changelog.d/README.md.

pront avatar Sep 11 '24 19:09 pront

@bruceg would you like to take another look before we merge this? There was a force push and multiple updates after you last reviewed.

pront avatar Oct 11 '24 19:10 pront

Many thanks @ChocPanda and @10x-mattsearle. In the future, please avoid force pushes because it makes it easier for the reviewer to see what changed. I will do another pass on this PR now 👍

pront avatar Oct 24 '24 17:10 pront