vector icon indicating copy to clipboard operation
vector copied to clipboard

fix(file source): Execute checkpoint migration for every new file for kubernetes_log source.

Open Rajin9601 opened this issue 1 year ago • 4 comments
trafficstars

fix https://github.com/vectordotdev/vector/issues/20798

Checkpoint migration was only executed when file_server is being initialized. However kubernetes_log's PathProvider doesn't load paths at the start-up (because it have to fetch k8s metadata). So for kubernetes_log, migration will not be executed.

This PR suggests executing checkpoint migration whenever a new file appears. Migration process is quite simple, so I don't think it's too computationally intensive.

Rajin9601 avatar Sep 09 '24 01:09 Rajin9601

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Sep 09 '24 01:09 bits-bot

@jszwedko sure! changelog entry is added here. https://github.com/vectordotdev/vector/pull/21231/commits/a224bec72c82ca05615613dc7f9344876c224f6b

Rajin9601 avatar Sep 12 '24 01:09 Rajin9601

Perfect, thanks @Rajin9601 !

jszwedko avatar Sep 12 '24 14:09 jszwedko

Just a note that make check-clippy is failing on this PR.

jszwedko avatar Sep 24 '24 22:09 jszwedko