vector icon indicating copy to clipboard operation
vector copied to clipboard

chore(enterprise)!: Remove `enterprise` feature

Open bruceg opened this issue 1 year ago • 1 comments
trafficstars

We probably do not want to actually merge this until closer to the next release, in case we discover reasons to leave it in, but I thought I would put this out here since I had already done the grunt work.

bruceg avatar May 09 '24 18:05 bruceg

Datadog Report

Branch report: remove-enterprise-feature Commit report: 7365f1f Test service: vector

:white_check_mark: 0 Failed, 9 Passed, 0 Skipped, 25.43s Total Time

Regression Detector Results

Run ID: 8e5dce99-0ded-44ab-af0f-3828f3cd2b43 Baseline: ceca9a102aa510fbec15f4ad1d56523e1dd51025 Comparison: 09841b3a525458ac4f9961e8e6c6ef4541d048d2 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

perf experiment goal Δ mean % Δ mean % CI
otlp_http_to_blackhole ingress throughput -5.19 [-5.33, -5.04]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
datadog_agent_remap_blackhole ingress throughput +2.18 [+2.07, +2.28]
datadog_agent_remap_blackhole_acks ingress throughput +0.90 [+0.82, +0.98]
fluent_elasticsearch ingress throughput +0.89 [+0.41, +1.37]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.78 [+0.70, +0.86]
splunk_hec_route_s3 ingress throughput +0.53 [+0.07, +0.98]
datadog_agent_remap_datadog_logs ingress throughput +0.15 [+0.04, +0.26]
http_to_http_noack ingress throughput +0.13 [+0.04, +0.22]
syslog_loki ingress throughput +0.10 [+0.06, +0.14]
syslog_humio_logs ingress throughput +0.03 [-0.10, +0.15]
http_to_http_json ingress throughput +0.02 [-0.06, +0.09]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.14, +0.14]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.03 [-0.14, +0.09]
http_elasticsearch ingress throughput -0.03 [-0.10, +0.03]
otlp_grpc_to_blackhole ingress throughput -0.05 [-0.14, +0.04]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.24 [-0.37, -0.11]
http_to_http_acks ingress throughput -0.29 [-1.65, +1.06]
http_to_s3 ingress throughput -0.43 [-0.71, -0.15]
syslog_splunk_hec_logs ingress throughput -0.50 [-0.58, -0.42]
syslog_log2metric_humio_metrics ingress throughput -0.51 [-0.60, -0.41]
file_to_blackhole egress throughput -0.57 [-3.00, +1.86]
syslog_regex_logs2metric_ddmetrics ingress throughput -0.67 [-0.74, -0.61]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -1.31 [-1.45, -1.16]
http_text_to_http_json ingress throughput -1.70 [-1.82, -1.58]
socket_to_socket_blackhole ingress throughput -2.23 [-2.30, -2.16]
otlp_http_to_blackhole ingress throughput -5.19 [-5.33, -5.04]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

github-actions[bot] avatar Jun 10 '24 23:06 github-actions[bot]

Regression Detector Results

Run ID: 753fb420-09aa-416c-9990-beee8329820b Baseline: 58114f1345c1fe33807d14f0c8f8ae9087919d19 Comparison: 4f5c99d1afbab12e7d86349f7f269c74fcc7814b Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otlp_http_to_blackhole ingress throughput +2.51 [+2.39, +2.63]
syslog_log2metric_splunk_hec_metrics ingress throughput +1.47 [+1.33, +1.60]
datadog_agent_remap_datadog_logs_acks ingress throughput +1.35 [+1.27, +1.43]
splunk_hec_route_s3 ingress throughput +0.65 [+0.19, +1.12]
datadog_agent_remap_blackhole_acks ingress throughput +0.55 [+0.46, +0.63]
otlp_grpc_to_blackhole ingress throughput +0.49 [+0.40, +0.58]
syslog_loki ingress throughput +0.49 [+0.38, +0.59]
datadog_agent_remap_datadog_logs ingress throughput +0.23 [+0.13, +0.34]
socket_to_socket_blackhole ingress throughput +0.23 [+0.14, +0.31]
datadog_agent_remap_blackhole ingress throughput +0.20 [+0.11, +0.29]
http_to_http_noack ingress throughput +0.16 [+0.06, +0.26]
http_to_http_json ingress throughput +0.02 [-0.05, +0.09]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.14, +0.14]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.15, +0.15]
http_to_s3 ingress throughput -0.04 [-0.31, +0.23]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.06 [-0.18, +0.05]
syslog_log2metric_humio_metrics ingress throughput -0.10 [-0.20, -0.01]
syslog_humio_logs ingress throughput -0.13 [-0.26, -0.01]
http_elasticsearch ingress throughput -0.52 [-0.59, -0.44]
http_to_http_acks ingress throughput -0.53 [-1.88, +0.83]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.53 [-0.66, -0.40]
http_text_to_http_json ingress throughput -0.58 [-0.71, -0.45]
syslog_splunk_hec_logs ingress throughput -0.73 [-0.81, -0.66]
fluent_elasticsearch ingress throughput -0.89 [-1.38, -0.40]
file_to_blackhole egress throughput -1.15 [-3.70, +1.39]
syslog_regex_logs2metric_ddmetrics ingress throughput -1.63 [-1.75, -1.52]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

github-actions[bot] avatar Jun 11 '24 02:06 github-actions[bot]