vector icon indicating copy to clipboard operation
vector copied to clipboard

Replace heim with sysinfo [ fix build on FreeBSD ]

Open yonas opened this issue 1 year ago • 1 comments

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

Replacing heim with sysinfo will fix building on FreeBSD.

Configuration

No response

Version

0.37.1

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response

yonas avatar May 01 '24 21:05 yonas

As mentioned in https://github.com/vectordotdev/vector/pull/10614 we could also support FreeBSD by disabling the host_metrics source for it. There is already some precedent for platform specific sources (mostly between Linux and Windows). This is likely to be less work than swapping out heim for sysinfo. I think we'd also like to see an RFC comparing the alternatives, and whether sysinfo can satisfy the currently published metrics by the host_metrics source before moving forward with sysinfo.

sysinfo was compared at the time heim was chosen (see https://github.com/vectordotdev/vector/blob/master/rfcs/2020-08-26-3191-host-metrics.md). Granted that was when heim was still maintained and sysinfo lacked FreeBSD support.

jszwedko avatar May 03 '24 18:05 jszwedko