vector
vector copied to clipboard
fix(healthchecks): instrument healthchecks with component span
Fixes #20356
This instruments the healthcheck task with the sink component span.
The aws s3 sink healthcheck sends a request to check the bucket can be written to. During the AWS upgrade a wrapper over the http connection was created that could instrument the bytes sent. Since the healthcheck was not being instrumented this resulted in an empty component_sent_bytes_total being emitted.
I am quite surprised that this error hasn't cropped up sooner, so it is well worth double checking that I am fixing this the correct way.
Datadog Report
Branch report: stephen/instrument_healthchecks
Commit report: 9c07ae3
Test service: vector
:white_check_mark: 0 Failed, 87 Passed, 0 Skipped, 4m 31.58s Wall Time
Pushed code to use a flag to not emit. Still need to -
- [ ] Update PR title to more accurately describe what it's doing
- [ ] Check all the AWS components to ensure they all do this.
Moving to draft until I do those..