vector chore(splunk hec sink)!: json encoding should get message first and then parse

chore(splunk hec sink)!: json encoding should get message first and then parse

Open pront opened this issue 1 year ago • 4 comments

trafficstars

Apr 12 '24 23:04 pront

Putting this out there to potentially get some feedback, I will revisit on Monday.

Apr 12 '24 23:04 pront

Branch report: pront/OPA-1526_splunk_sink_enc_fix Commit report: dbde866 Test service: vector

:x: 11 Failed (0 Known Flaky), 2146 Passed, 0 Skipped, 19m 46.3s Wall Time

This report shows up to 5 failed tests.

sinks::humio::metrics::tests::multi_value_tags - vector
sinks::humio::metrics::tests::smoke_json - vector
sinks::splunk_hec::logs::integration_tests::splunk_auto_extracted_timestamp - vector - Details
Expand for error
```
est has failed
```
sinks::splunk_hec::logs::integration_tests::splunk_configure_hostname - vector - Details
Expand for error
```
est has failed
```
sinks::splunk_hec::logs::integration_tests::splunk_custom_fields - vector - Details
Expand for error
```
est has failed
```

Apr 12 '24 23:04 datadog-vectordotdev[bot]

Didn't mean to approve this PR 😓

I think this will be blocked until you re-approve. I suggest re-approving 😅 I won't merge until Vlad and Jesse take a look.

Apr 15 '24 21:04 pront

👋
Noting that we elected to hold off on this for the time being. We can revisit it if needed next week when Pavlos returns.

Thanks for all the input @jszwedko 🙇

Apr 17 '24 20:04 neuronull