vector icon indicating copy to clipboard operation
vector copied to clipboard

chore(dev, releasing): Have Cargo.toml `release` profile match what releases are published with

Open jszwedko opened this issue 1 year ago • 12 comments
trafficstars

Per https://github.com/vectordotdev/vector/pull/17342#issuecomment-1980949948 Linux distros commonly rebuild Vector rather than pulling in prebuilt artifacts. They could set the same profile flags we do (or even flags that are deemed to be better suited) but I do see value in "just" having the release profile match how we build and distribute release versions of Vector to serve as the default for anyone else building release builds.

The original intent of having CI set different release flags than were in Cargo.toml was to have faster local release builds when analyzing Vector performance. Now that custom profiles exist, which didn't at the time, I added a custom profile, dev-perf, to be used for this purpose instead.

Ref: https://github.com/vectordotdev/vector/pull/17342#issuecomment-1980949948

jszwedko avatar Mar 07 '24 21:03 jszwedko

Datadog Report

Branch report: jszwedko/release-profile-default Commit report: 2356911 Test service: vector

:white_check_mark: 0 Failed, 7 Passed, 0 Skipped, 25.38s Wall Time

/ci-run-all

jszwedko avatar Mar 11 '24 18:03 jszwedko

/ci-run-all

jszwedko avatar Mar 11 '24 19:03 jszwedko

/ci-run-all

jszwedko avatar Mar 11 '24 21:03 jszwedko

Regression Detector Results

Run ID: bf565250-5af8-45d0-a893-0109b04eee89 Baseline: 4804e1745170dab2075fe6ef27534d57033ec2f7 Comparison: f79bde7275662f06c5c93ebe2f71cdaa52b4ed35 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

perf experiment goal Δ mean % Δ mean % CI
syslog_humio_logs ingress throughput +15.43 [+15.30, +15.56]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +15.11 [+15.01, +15.22]
syslog_log2metric_splunk_hec_metrics ingress throughput +15.01 [+14.87, +15.15]
syslog_regex_logs2metric_ddmetrics ingress throughput +14.74 [+14.62, +14.86]
syslog_loki ingress throughput +13.32 [+13.25, +13.39]
syslog_splunk_hec_logs ingress throughput +12.31 [+12.21, +12.41]
socket_to_socket_blackhole ingress throughput +11.25 [+11.18, +11.33]
syslog_log2metric_humio_metrics ingress throughput +9.61 [+9.46, +9.76]
datadog_agent_remap_blackhole_acks ingress throughput +9.29 [+9.17, +9.41]
otlp_http_to_blackhole ingress throughput +8.60 [+8.46, +8.74]
datadog_agent_remap_blackhole ingress throughput +8.18 [+8.08, +8.29]
datadog_agent_remap_datadog_logs_acks ingress throughput +7.08 [+7.00, +7.17]
otlp_grpc_to_blackhole ingress throughput +5.56 [+5.47, +5.65]
datadog_agent_remap_datadog_logs ingress throughput +5.54 [+5.42, +5.65]
splunk_hec_route_s3 ingress throughput +5.29 [+4.79, +5.79]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_humio_logs ingress throughput +15.43 [+15.30, +15.56]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +15.11 [+15.01, +15.22]
syslog_log2metric_splunk_hec_metrics ingress throughput +15.01 [+14.87, +15.15]
syslog_regex_logs2metric_ddmetrics ingress throughput +14.74 [+14.62, +14.86]
syslog_loki ingress throughput +13.32 [+13.25, +13.39]
syslog_splunk_hec_logs ingress throughput +12.31 [+12.21, +12.41]
socket_to_socket_blackhole ingress throughput +11.25 [+11.18, +11.33]
syslog_log2metric_humio_metrics ingress throughput +9.61 [+9.46, +9.76]
datadog_agent_remap_blackhole_acks ingress throughput +9.29 [+9.17, +9.41]
otlp_http_to_blackhole ingress throughput +8.60 [+8.46, +8.74]
datadog_agent_remap_blackhole ingress throughput +8.18 [+8.08, +8.29]
datadog_agent_remap_datadog_logs_acks ingress throughput +7.08 [+7.00, +7.17]
otlp_grpc_to_blackhole ingress throughput +5.56 [+5.47, +5.65]
datadog_agent_remap_datadog_logs ingress throughput +5.54 [+5.42, +5.65]
splunk_hec_route_s3 ingress throughput +5.29 [+4.79, +5.79]
fluent_elasticsearch ingress throughput +3.72 [+3.24, +4.20]
http_text_to_http_json ingress throughput +3.19 [+3.05, +3.34]
http_to_http_acks ingress throughput +0.79 [-0.53, +2.10]
http_to_s3 ingress throughput +0.19 [-0.08, +0.47]
http_to_http_noack ingress throughput +0.13 [+0.06, +0.21]
http_to_http_json ingress throughput +0.02 [-0.06, +0.10]
enterprise_http_to_http ingress throughput +0.01 [-0.05, +0.07]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.14]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.16, +0.15]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.01 [-0.13, +0.11]
file_to_blackhole egress throughput -0.01 [-2.47, +2.45]
http_elasticsearch ingress throughput -4.57 [-4.63, -4.51]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

github-actions[bot] avatar Mar 12 '24 03:03 github-actions[bot]

Regression Detector Results

Run ID: 1cf02af2-6d9b-41f3-ae63-07e5154a9a1e Baseline: a7c3dbc453dc63dd4499b8f0c3dce15f16839f46 Comparison: fdc1db7ccfa6880e7efe80c9b9bec74f86f36c79 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

perf experiment goal Δ mean % Δ mean % CI
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +14.22 [+14.07, +14.37]
syslog_log2metric_humio_metrics ingress throughput +13.15 [+13.02, +13.29]
syslog_log2metric_splunk_hec_metrics ingress throughput +12.71 [+12.54, +12.87]
syslog_loki ingress throughput +12.62 [+12.51, +12.72]
syslog_humio_logs ingress throughput +11.94 [+11.82, +12.06]
syslog_splunk_hec_logs ingress throughput +11.78 [+11.70, +11.86]
syslog_regex_logs2metric_ddmetrics ingress throughput +10.62 [+10.46, +10.78]
datadog_agent_remap_blackhole ingress throughput +9.82 [+9.69, +9.95]
splunk_hec_route_s3 ingress throughput +9.74 [+9.23, +10.24]
socket_to_socket_blackhole ingress throughput +7.10 [+7.02, +7.18]
fluent_elasticsearch ingress throughput +6.48 [+5.99, +6.97]
otlp_grpc_to_blackhole ingress throughput +6.42 [+6.33, +6.51]
datadog_agent_remap_blackhole_acks ingress throughput +6.34 [+6.22, +6.46]
datadog_agent_remap_datadog_logs ingress throughput +6.17 [+6.06, +6.29]
datadog_agent_remap_datadog_logs_acks ingress throughput +5.13 [+5.04, +5.22]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +14.22 [+14.07, +14.37]
syslog_log2metric_humio_metrics ingress throughput +13.15 [+13.02, +13.29]
syslog_log2metric_splunk_hec_metrics ingress throughput +12.71 [+12.54, +12.87]
syslog_loki ingress throughput +12.62 [+12.51, +12.72]
syslog_humio_logs ingress throughput +11.94 [+11.82, +12.06]
syslog_splunk_hec_logs ingress throughput +11.78 [+11.70, +11.86]
syslog_regex_logs2metric_ddmetrics ingress throughput +10.62 [+10.46, +10.78]
datadog_agent_remap_blackhole ingress throughput +9.82 [+9.69, +9.95]
splunk_hec_route_s3 ingress throughput +9.74 [+9.23, +10.24]
socket_to_socket_blackhole ingress throughput +7.10 [+7.02, +7.18]
fluent_elasticsearch ingress throughput +6.48 [+5.99, +6.97]
otlp_grpc_to_blackhole ingress throughput +6.42 [+6.33, +6.51]
datadog_agent_remap_blackhole_acks ingress throughput +6.34 [+6.22, +6.46]
datadog_agent_remap_datadog_logs ingress throughput +6.17 [+6.06, +6.29]
datadog_agent_remap_datadog_logs_acks ingress throughput +5.13 [+5.04, +5.22]
otlp_http_to_blackhole ingress throughput +4.40 [+4.27, +4.53]
http_text_to_http_json ingress throughput +3.92 [+3.76, +4.09]
file_to_blackhole egress throughput +0.89 [-1.62, +3.40]
http_to_http_noack ingress throughput +0.21 [+0.12, +0.30]
http_to_s3 ingress throughput +0.16 [-0.12, +0.44]
http_to_http_json ingress throughput +0.03 [-0.05, +0.10]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.15, +0.15]
splunk_hec_indexer_ack_blackhole ingress throughput -0.01 [-0.15, +0.13]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.05 [-0.16, +0.07]
enterprise_http_to_http ingress throughput -0.07 [-0.14, -0.01]
http_to_http_acks ingress throughput -0.21 [-1.52, +1.11]
http_elasticsearch ingress throughput -3.67 [-3.76, -3.58]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

github-actions[bot] avatar Mar 12 '24 19:03 github-actions[bot]

/ci-run-k8s

jszwedko avatar Mar 12 '24 19:03 jszwedko

/ci-run-k8s

jszwedko avatar Mar 22 '24 22:03 jszwedko

/ci-run-k8s

jszwedko avatar Mar 22 '24 22:03 jszwedko

/ci-run-k8s

jszwedko avatar Mar 22 '24 23:03 jszwedko

/ci-run-k8s

jszwedko avatar Mar 22 '24 23:03 jszwedko

/ci-run-k8s

jszwedko avatar Mar 22 '24 23:03 jszwedko